Skip to content

Handle whitespace when calculating usernames #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AA-Turner merged 2 commits into from
Sep 17, 2024
Merged

Handle whitespace when calculating usernames #132

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9069bf
Handle whitespace when calculating usernames
AA-Turner Sep 16, 2024
efc4c86
Add test, strip all whitespace
AA-Turner Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cherry_picker/cherry_picker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def sorted_branches(self):
@property
def username(self):
cmd = ["git", "config", "--get", f"remote.{self.pr_remote}.url"]
result = self.run_cmd(cmd, required_real_result=True)
result = self.run_cmd(cmd, required_real_result=True).strip("\n")
Comment thread
AA-Turner marked this conversation as resolved.
Outdated
# implicit ssh URIs use : to separate host from user, others just use /
username = result.replace(":", "/").rstrip("/").split("/")[-2]
return username
Expand Down