Conversation
|
Thanks! FYI, earlier CI noise was due to aligning the Towncrier fragment naming with Chronographer and whitelisting |
| @@ -380,6 +380,7 @@ exclude_also = [ | |||
| git-only = [ | |||
| "tests/**", | |||
| "tools/**", | |||
| "news/**", | |||
There was a problem hiding this comment.
What is the point of this change? It seems unrelated to the purpose of the PR.
|
Good point - it isn’t directly related to the UX fix. I added it while addressing CI failures around the Towncrier fragment, but I agree it’s scope creep for this PR. I’ve reverted the check-sdist change; if the project wants an explicit adjustment for Towncrier fragments, I can follow up with a dedicated PR. |
|
Your NEWS entry is named incorrectly. See here:
Please fix the filename and rebase the PR to remove the spurious commits messing with the news file and whitelisting. |
|
Thanks for the review! I've renamed the news fragment to |
|
Thanks for the fix for this small, but annoying, issue! 🙂 |
Fixes #13226.
When a constraint file path is missing/unreadable (via -c/--constraint or PIP_CONSTRAINT), pip reported "Could not open requirements file", which is misleading.
This change passes the existing
constraintcontext intoget_file_content()and tailors the InstallationError message to say "constraint file" when appropriate.Tests: add a unit test asserting the correct message for
constraint=True.