fix: don't build universal2 as a default on macOS arm64 runners - #1217
Merged
Conversation
Contributor
|
Just pushed a few docs updates. The only other thing I was wondering about was removing this line: Line 203 in 03c8f5b ...because we no longer expect it to be built by default. Or perhaps we need another parameter on |
Contributor
|
I pushed a commit that should fix the expected_wheels thing. Of course, we'll only know once we try it on an arm64 CI, which should be coming in #1191 ! |
henryiii
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #1204, only build
arm64on arm64 macOS runners.Fixes #1204
Relates to #1191