Skip to content

Fix log level in examples #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janiversen merged 2 commits into from
Mar 12, 2026
Merged

Fix log level in examples #2902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d150f4
Fix log level in examples
KevinWMatthews Mar 12, 2026
5ecbdfc
Merge branch 'dev' into km/fix-logging-in-examples
janiversen Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions examples/client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@
import pymodbus.client as modbusClient


_logger = logging.getLogger(__file__)
_logger.setLevel("DEBUG")
_logger = logging.getLogger(__name__)


def setup_async_client(description: str | None =None, cmdline: list[str] | None = None) -> modbusClient.ModbusBaseClient:
Expand Down
1 change: 0 additions & 1 deletion examples/client_async_calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
sys.exit(-1)

_logger = logging.getLogger(__file__)
_logger.setLevel("DEBUG")


DEVICE_ID = 0x01
Expand Down
1 change: 0 additions & 1 deletion examples/client_calls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@


_logger = logging.getLogger(__file__)
_logger.setLevel("DEBUG")


DEVICE_ID = 0x01
Expand Down
1 change: 0 additions & 1 deletion examples/client_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@


_logger = logging.getLogger(__file__)
_logger.setLevel("DEBUG")


def setup_sync_client(description=None, cmdline=None):
Expand Down
1 change: 1 addition & 0 deletions examples/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ def get_commandline(server: bool = False, description: str | None = None, extras
"tls": ["tls", 5020],
}
pymodbus_apply_logging_config(args.log.upper())
logging.basicConfig(level=args.log.upper())
_logger.setLevel(args.log.upper())
if not args.framer:
args.framer = comm_defaults[args.comm][0]
Expand Down
1 change: 0 additions & 1 deletion examples/server_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@


_logger = logging.getLogger(__file__)
_logger.setLevel(logging.INFO)


def setup_server(description=None, context=None, cmdline=None):
Expand Down
1 change: 0 additions & 1 deletion examples/server_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@


_logger = logging.getLogger(__name__)
_logger.setLevel("DEBUG")


def run_sync_server(args) -> None:
Expand Down