-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Initial abi3t support #15063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Initial abi3t support #15063
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8575c91
enable abi3t builds
ngoldbaum ae2cd86
Merge branch 'main' into abi3t
ngoldbaum 9c105f9
Add 3.15(t) CI jobs
ngoldbaum a70b4e0
Attempt using upstream versions
ngoldbaum 5f167cb
Don't define _Py_OPAQUE_PYOBJECT, Python does that for us
ngoldbaum 6f8fff6
Depend on maturin's 'main' branch
ngoldbaum 56e344d
Depend on maturin's git repo
ngoldbaum f1a2c7a
Use pyo3-build-config to get ABI info in the CFFI crate
ngoldbaum 1c420f5
temporarily depend on my maturin PR branch
ngoldbaum da1c873
Require maturin 1.14.1 or newer on 3.15 or newer
ngoldbaum e83c831
Require Maturin 1.14.1 or newer
ngoldbaum 7c9e0cb
Merge branch 'main' into abi3t
ngoldbaum 1144578
Merge branch 'main' into abi3t
ngoldbaum 4f3c277
Depend on upstream CFFI
ngoldbaum ded1529
Update build-requirements
ngoldbaum b921367
Depend on CFFI>=2.1 on >=3.15
ngoldbaum 3e9429c
Don't depend on CFFI on a future PyPy 3.15
ngoldbaum File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh, do we need the
and platform_python_implementation != 'PyPy'just in case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure we're safe given the status of Python 3.12 support in PyPy, but let's add it just to cover our bases I guess...
https://github.com/orgs/pypy/discussions/5145