Prefer charset_normalizer for char detection#6714
Closed
Conversation
charset_normalizer is dependency for requests, while chardet is not, so it is more likely to be found.
This was referenced May 22, 2024
Contributor
|
Just don't install chardet |
Author
|
I'd love to, but it's a dependency for a third-party library (otsaloma/gaupol#222). What is actually the reason for trying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charset_normalizeris a dependency for requests, whilechardetis not, so it is more likely to be found.For vendored requests this would still load whatever is available.
The reason I noticed this memory profiling in case both libraries are present and
charset_normalizerhas way lower memory footprint thanchardet.