Add note on connection timeout being larger than specified. Fix #5773#6600
Merged
sigmavirus24 merged 3 commits intopsf:mainfrom Dec 16, 2023
Merged
Conversation
Contributor
Author
|
Is there anything I can do on my part to fix the build errors, or are the docs test suite broken? |
fix indentation for note so it renders properly
Add note about wall clock too
sigmavirus24
approved these changes
Dec 16, 2023
Contributor
|
Thank you @MestreLion ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested, here's my take on a PR to improve documentation. I've tried to incorporate the suggestions made by @sigmavirus24 at a previous PR, by shifting the focus from "IPv4+IPv6" particular case to a more general (and correct) "multiple IPs" scenario.
If approved, this PR will also fix #5760, and supersede PRs #5776 and #6597