Skip to content

docs(socks): same block as other sections#6553

Merged
nateprewitt merged 1 commit intopsf:mainfrom
magsen:patch-1
Mar 25, 2026
Merged

docs(socks): same block as other sections#6553
nateprewitt merged 1 commit intopsf:mainfrom
magsen:patch-1

Conversation

@magsen
Copy link
Copy Markdown
Contributor

@magsen magsen commented Oct 18, 2023

@sigmavirus24
Copy link
Copy Markdown
Contributor

sigmavirus24 commented Oct 18, 2023

The current formatting looks correct to me. What looks wrong to you?

@magsen
Copy link
Copy Markdown
Contributor Author

magsen commented Oct 18, 2023

i have some kind of strange underscore

image

In a private firefox without dark theme
image
image

https://github.com/psf/requests/blob/main/docs/user/advanced.rst

In the rst preview you can see that this bash code block is not the same as the other bash code bloc

@sigmavirus24
Copy link
Copy Markdown
Contributor

sigmavirus24 commented Oct 18, 2023

I cannot replicate that on Firefox on macOS or Linux

@sigmavirus24
Copy link
Copy Markdown
Contributor

sigmavirus24 commented Oct 18, 2023

I cannot replicate that on Firefox on macOS or Linux.

I would be willing to entertain a PR, however that adds sphinx-prompt to our docs dependencies and switches this to using .. prompt:: instead because that's more correct

@nateprewitt
Copy link
Copy Markdown
Member

nateprewitt commented Oct 18, 2023 •
edited
Loading

I am actually able to replicate this on macOS in Firefox 115.3.1esr (64-bit). It appears whitespace in these blocks are being replaced with span tags with the w CSS class from pygments. This adds a faint white (#f8f8f8) underline to each whitespace.

Screenshot 2023-10-18 at 12 26 22 PM

I don't however immediately see why this is being added specifically for the bash codeblock. I'm fine moving to the simplified syntax (::) (or .. prompt:: as Ian noted) in this case since the bash formatting doesn't materially change the output, but it would be interesting to understand why it's happening.

@sigmavirus24
Copy link
Copy Markdown
Contributor

sigmavirus24 commented Oct 18, 2023

To find out why it's happening I suspect we'll need a pygments bug to investigate.

The span doesn't change what you copy out of the text though

nateprewitt
nateprewitt approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This never got merged. I'll do that now.

@nateprewitt nateprewitt merged commit 774a0b8 into psf:main Mar 25, 2026
26 checks passed
This was referenced Mar 27, 2026
Merged
Merged
Merged
penberg added a commit to tursodatabase/turso that referenced this pull request Apr 22, 2026
@penberg
Merge 'Bump requests from 2.32.5 to 2.33.0' from app/dependabot
ae1886c 
Bumps [requests](https://github.com/psf/requests) from 2.32.5 to 2.33.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/psf/requests/releases">requests's
releases</a>.</em></p>
<blockquote>
<h2>v2.33.0</h2>
<h2>2.33.0 (2026-03-25)</h2>
<p><strong>Announcements</strong></p>
<ul>
<li>📣 Requests is adding inline types. If you have a typed code base
that uses Requests, please take a look at <a
href="https://redirect.github.com/psf/requests/issues/7271">#7271</a>.
Give it a try, and report any gaps or feedback you may have in the
issue. 📣</li>
</ul>
<p><strong>Security</strong></p>
<ul>
<li>CVE-2026-25645 <code>requests.utils.extract_zipped_paths</code> now
extracts contents to a non-deterministic location to prevent malicious
file replacement. This does not affect default usage of Requests, only
applications calling the utility function directly.</li>
</ul>
<p><strong>Improvements</strong></p>
<ul>
<li>Migrated to a PEP 517 build system using setuptools. (<a href="https
://redirect.github.com/psf/requests/issues/7012">#7012</a>)</li>
</ul>
<p><strong>Bugfixes</strong></p>
<ul>
<li>Fixed an issue where an empty netrc entry could cause malformed
authentication to be applied to Requests on Python 3.11+. (<a href="http
s://redirect.github.com/psf/requests/issues/7205">#7205</a>)</li>
</ul>
<p><strong>Deprecations</strong></p>
<ul>
<li>Dropped support for Python 3.9 following its end of support. (<a hre
f="https://redirect.github.com/psf/requests/issues/7196">#7196</a>)</li>
</ul>
<p><strong>Documentation</strong></p>
<ul>
<li>Various typo fixes and doc improvements.</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/M0d3v1"><code>@​M0d3v1</code></a> made
their first contribution in <a href="https://redirect.github.com/psf/req
uests/pull/6865">psf/requests#6865</a></li>
<li><a href="https://github.com/aminvakil"><code>@​aminvakil</code></a>
made their first contribution in <a href="https://redirect.github.com/ps
f/requests/pull/7220">psf/requests#7220</a></li>
<li><a href="https://github.com/E8Price"><code>@​E8Price</code></a> made
their first contribution in <a href="https://redirect.github.com/psf/req
uests/pull/6960">psf/requests#6960</a></li>
<li><a href="https://github.com/mitre88"><code>@​mitre88</code></a> made
their first contribution in <a href="https://redirect.github.com/psf/req
uests/pull/7244">psf/requests#7244</a></li>
<li><a href="https://github.com/magsen"><code>@​magsen</code></a> made
their first contribution in <a href="https://redirect.github.com/psf/req
uests/pull/6553">psf/requests#6553</a></li>
<li><a
href="https://github.com/Rohan5commit"><code>@​Rohan5commit</code></a>
made their first contribution in <a href="https://redirect.github.com/ps
f/requests/pull/7227">psf/requests#7227</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/psf/requ
ests/blob/main/HISTORY.md#2330-2026-03-
25">https://github.com/psf/requests/blob/main/HISTORY.md#2330-2026-03-
25</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/psf/requests/blob/main/HISTORY.md">requests's
changelog</a>.</em></p>
<blockquote>
<h2>2.33.0 (2026-03-25)</h2>
<p><strong>Announcements</strong></p>
<ul>
<li>📣 Requests is adding inline types. If you have a typed code base
that
uses Requests, please take a look at <a
href="https://redirect.github.com/psf/requests/issues/7271">#7271</a>.
Give it a try, and report
any gaps or feedback you may have in the issue. 📣</li>
</ul>
<p><strong>Security</strong></p>
<ul>
<li>CVE-2026-25645 <code>requests.utils.extract_zipped_paths</code> now
extracts
contents to a non-deterministic location to prevent malicious file
replacement. This does not affect default usage of Requests, only
applications calling the utility function directly.</li>
</ul>
<p><strong>Improvements</strong></p>
<ul>
<li>Migrated to a PEP 517 build system using setuptools. (<a href="https
://redirect.github.com/psf/requests/issues/7012">#7012</a>)</li>
</ul>
<p><strong>Bugfixes</strong></p>
<ul>
<li>Fixed an issue where an empty netrc entry could cause
malformed authentication to be applied to Requests on
Python 3.11+. (<a href="https://redirect.github.com/psf/requests/issues/
7205">#7205</a>)</li>
</ul>
<p><strong>Deprecations</strong></p>
<ul>
<li>Dropped support for Python 3.9 following its end of support. (<a hre
f="https://redirect.github.com/psf/requests/issues/7196">#7196</a>)</li>
</ul>
<p><strong>Documentation</strong></p>
<ul>
<li>Various typo fixes and doc improvements.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="psf/requests@bc04dfd6dad4cb02cd92
f5daa81eb562d280a761"><code>bc04dfd</code></a> v2.33.0</li>
<li><a href="psf/requests@66d21cb07bd6255b1280
291c4fafb71803cdb3b7"><code>66d21cb</code></a> Merge commit from
fork</li>
<li><a href="psf/requests@8b9bc8fc0f63be846023
87913c4b689f19efd028"><code>8b9bc8f</code></a> Move badges to top of
README (<a href="https://redirect.github.com/psf/requests/issues/7293">#
7293</a>)</li>
<li><a href="psf/requests@e331a288f369973f5de0
ec8901c94cae4fa87286"><code>e331a28</code></a> Remove unused extraction
call (<a href="https://redirect.github.com/psf/requests/issues/7292">#72
92</a>)</li>
<li><a href="psf/requests@753fd08c5eacce0aa0df
73fe47e49525c67e0a29"><code>753fd08</code></a> docs: fix FAQ grammar in
httplib2 example</li>
<li><a href="psf/requests@774a0b837a194ee885d4
fdd9ca947900cc3daf71"><code>774a0b8</code></a> docs(socks): same block
as other sections</li>
<li><a href="psf/requests@9c72a41bec8597f948c9
d8caa5dc3f12273b3303"><code>9c72a41</code></a> Bump github/codeql-action
from 4.33.0 to 4.34.1</li>
<li><a href="psf/requests@ebf71906798ec82f34e0
7d3168f8b8aecaf8a3be"><code>ebf7190</code></a> Bump github/codeql-action
from 4.32.0 to 4.33.0</li>
<li><a href="psf/requests@0e4ae38f0c93d4f92a96
c774bd52c069d12a4798"><code>0e4ae38</code></a> docs: exclude
Response.is_permanent_redirect from API docs (<a href="https://redirect.
github.com/psf/requests/issues/7244">#7244</a>)</li>
<li><a href="psf/requests@d568f47278492e630cc9
90a259047c67991d007a"><code>d568f47</code></a> docs: clarify Quickstart
POST example (<a href="https://redirect.github.com/psf/requests/issues/6
960">#6960</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/psf/requests/compare/v2.32.5...v2.33.0">compare
view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-
badges.githubapp.com/badges/compatibility_score?dependency-
name=requests&package-manager=uv&previous-version=2.32.5&new-
version=2.33.0)](https://docs.github.com/en/github/managing-security-
vulnerabilities/about-dependabot-security-updates#about-compatibility-
scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/tursodatabase/turso/network/alerts).
</details>

Closes #6527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nateprewitt nateprewitt nateprewitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@magsen @sigmavirus24 @nateprewitt