Skip to content

Missing assert in test_requests.py test_header_validation #6551

@Sjord

Description

@Sjord

requests/tests/test_requests.py at main · psf/requests

    def test_header_validation(self, httpbin):
        """Ensure prepare_headers regex isn't flagging valid header contents."""
        valid_headers = {
            "foo": "bar baz qux",
            "bar": b"fbbq",
            "baz": "",
            "qux": "1",
        }
        r = requests.get(httpbin("get"), headers=valid_headers)
        for key in valid_headers.keys():
            valid_headers[key] == r.request.headers[key]

valid_headers[key] == r.request.headers[key] should probably be assert valid_headers[key] == r.request.headers[key].

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions