Make update_version.py compatible with Python 3 - #8555
Merged
Conversation
acozzette
force-pushed
the
update-version-script
branch
from
May 3, 2021 23:19
8eacc2d to
e2901d1
Compare
acozzette
force-pushed
the
update-version-script
branch
from
May 3, 2021 23:20
e2901d1 to
41039d7
Compare
haberman
reviewed
May 3, 2021
| file_handle.write(content) | ||
| file_handle.write('\n') | ||
| file_handle.write(b'<?xml version="1.0" encoding="UTF-8"?>\n') | ||
| file_handle.write(content.encode('utf-8')) |
haberman
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.