bugfix: unexpected output when decoding maps with long keys#1870
Open
andrewyang96 wants to merge 2 commits into
Open
bugfix: unexpected output when decoding maps with long keys#1870andrewyang96 wants to merge 2 commits into
andrewyang96 wants to merge 2 commits into
Conversation
|
can anyone helps review that bugfix please? |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
protobuf.js version: 7.2.2
Resolves #1203
As illustrated in the attached test,
{"1":"2"}is transformed into{"\x01\x00\x00\x00\x00\x00\x00\x00":2}without the decoder fix. Applyingutil.longToHashto the long key value here isn't necessary