Skip to content

feat: support message verify unsigned int#1670

Open
SzHeJason wants to merge 2 commits into
protobufjs:masterfrom
SzHeJason:feat/verify-unsigned-int
Open

feat: support message verify unsigned int#1670
SzHeJason wants to merge 2 commits into
protobufjs:masterfrom
SzHeJason:feat/verify-unsigned-int

Conversation

@SzHeJason

Copy link
Copy Markdown

Message.verify is not sensitive for use negative number on uint32

package awesomepackage;
syntax = "proto3";

message AwesomeMessage {
    uint32 awesome_field = 1; // becomes awesomeField
}
protobuf.load(path.join(__dirname, "awesome.proto"), function (err, root) {
  if (err)
    throw err;

  // Obtain a message type
  const AwesomeMessage = root!.lookupType("awesomepackage.AwesomeMessage");

  // Exemplary payload
  const payload = { awesomeField: -1 };

  // Verify the payload if necessary (i.e. when possibly incomplete or invalid)
  const errMsg = AwesomeMessage.verify(payload);

  // errMsg equal null
  if (errMsg){
    throw Error(errMsg);
  }
});

The Behavior make grpc service get incorrect value
eg: send -1 get 4294967295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant