Add resctrlfs package - #862
Merged
Merged
Conversation
Parse the monitoring data of the resctrl filesystem, the kernel interface to Intel RDT, AMD PQoS and ARM MPAM. All vendors share the same driver and file layout, so one parser serves all vendors. MonData returns the per domain counters of the root control group (llc_occupancy, mbm_total_bytes, mbm_local_bytes). A counter is nil when the hardware lacks the feature or reports "Unavailable". L3MonInfo exposes the monitoring capabilities from info/L3_MON. This patch only adds read support for monitoring data. Signed-off-by: René Treffer <treffer@measite.de>
rtreffer
marked this pull request as ready for review
August 26, 2026 14:01
SuperQ
approved these changes
Aug 27, 2026
SuperQ
left a comment
SuperQ
left a comment
Member
There was a problem hiding this comment.
Seems legit.
Dealing with Unavailable is tricky. But I think returning nil is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse the monitoring data of the resctrl filesystem, the kernel interface to Intel RDT, AMD PQoS and ARM MPAM. All vendors share the same driver and file layout, so one parser serves all vendors.
MonData returns the per domain counters of the root control group (llc_occupancy, mbm_total_bytes, mbm_local_bytes). A counter is nil when the hardware lacks the feature or reports "Unavailable". L3MonInfo exposes the monitoring capabilities from info/L3_MON.
This patch only adds read support for monitoring data.
Signed-off-by: René Treffer treffer@measite.de
Reviewers
AI disclosure: This code was written with the help of AI.
I did read through the code and everything looks as expected.
I have tested this with a new
node_exportercollector (resctrl).