Skip to content

Convert circleci config to 2.0. - #844

Merged
SuperQ merged 1 commit into
masterfrom
superq/circle2
Mar 8, 2018
Merged

Convert circleci config to 2.0.#844
SuperQ merged 1 commit into
masterfrom
superq/circle2

Conversation

@SuperQ

@SuperQ SuperQ commented Mar 6, 2018

Copy link
Copy Markdown
Member

No description provided.

@SuperQ
SuperQ requested a review from matthiasr March 6, 2018 17:15
@grobie

grobie commented Mar 6, 2018

Copy link
Copy Markdown
Member

Cool, I was waiting for the first one to move to ask "can you do that on all repos please" :D

@SuperQ

SuperQ commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

@grobie hah! Yea, there's a bunch of stuff that's easier in 2.0 configs. But, as you can see, it's not working perfectly yet with docker mode. Not sure why. :-/

@sdurrheimer

Copy link
Copy Markdown
Contributor

Nice, I was going to look at this.

@SuperQ

SuperQ commented Mar 6, 2018

Copy link
Copy Markdown
Member Author

@sdurrheimer promu crossbuild failed, not sure why.

@sdurrheimer

Copy link
Copy Markdown
Contributor

@SuperQ Can you add a -v to promu crossbuild to see more debug informations ?

@SuperQ
SuperQ force-pushed the superq/circle2 branch 6 times, most recently from cd3f175 to f424f7b Compare March 7, 2018 15:12
@SuperQ SuperQ changed the title WIP: Convert circleci config to 2.0. Convert circleci config to 2.0. Mar 7, 2018
@SuperQ
SuperQ requested a review from grobie March 7, 2018 15:49
@SuperQ

SuperQ commented Mar 7, 2018

Copy link
Copy Markdown
Member Author

@grobie @matthiasr The test and build workflow steps now work reliably. The publish steps should work now as well, but we need to try cutting an actual release from master to test them end-to-end.

@matthiasr

Copy link
Copy Markdown
Contributor

Let's cut an 0.16 beta then?

@SuperQ

SuperQ commented Mar 8, 2018

Copy link
Copy Markdown
Member Author

@matthiasr Yup, that's the plan, I want to cut it as rc0.

@matthiasr matthiasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@grobie

grobie commented Mar 8, 2018

Copy link
Copy Markdown
Member

So this config uses a lot more hardcoded names now, where we previously used template variables. This makes it a lot more cumbersome to keep our circle CI configs in sync between projects. Can you bring back the environment variables to reference the repo+organization names?

@SuperQ

SuperQ commented Mar 8, 2018

Copy link
Copy Markdown
Member Author

@grobie Based on the documentation I've read so far, the working_directory key doesn't interpret env vars. I can give it a try anyway.

oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
arunsrini3082 pushed a commit to arunsrini3082/node_exporter that referenced this pull request Jul 17, 2026
Signed-off-by: Arun S <arun.srinivasan@flipkart.com>
arunsrini3082 pushed a commit to arunsrini3082/node_exporter that referenced this pull request Aug 9, 2026
Signed-off-by: Arun S <arun.srinivasan@flipkart.com>
arunsrini3082 pushed a commit to arunsrini3082/node_exporter that referenced this pull request Aug 22, 2026
Signed-off-by: Arun S <arun.srinivasan@flipkart.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants