filesystem collector: use correct block size unit on NetBSD - #3800
Open
recursivetree wants to merge 1 commit into
Open
filesystem collector: use correct block size unit on NetBSD#3800recursivetree wants to merge 1 commit into
recursivetree wants to merge 1 commit into
Conversation
F_blocks, F_bfree and F_bavail is in units of f_frsize. See https://nxr.netbsd.org/xref/src/sys/sys/statvfs.h#72 Signed-off-by: Yuri Honegger <yurix@netbsd.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the filesystem exporter is reporting wrong values for
node_filesystem_avail_bytes,node_filesystem_free_bytes, andnode_filesystem_size_bytes. These values come from a SYS_GETVFSSTAT syscall and are originally in blocks, not bytes. To convert them to blocks, the filesystem collector uses the wrong factor (f_bsizeinseat off_frsize). See https://nxr.netbsd.org/xref/src/sys/sys/statvfs.h#72This PR fixes the converter so it export the correct values. However, this will cause a discontinuity in the data for existing installs. I don't know how this is usually handled/if this is acceptable.
Unrelated: While testing this PR I ran into some compile errors in
filesystem_netbsd.goaround debug logging. I've just commented them out to test this.