Skip to content

Add a fallback for when project version is unspecified #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
catilac merged 3 commits into from
Jul 3, 2026
Merged

Add a fallback for when project version is unspecified #1536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aff6b7c
Add a fallback for when project version is `unspecified`
catilac Jul 3, 2026
3e81723
Merge branch 'main' into fix-processing-plugin-test
catilac Jul 3, 2026
14d877c
Run PDEWelcomeTests headless
catilac Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ dependencies {
}

tasks.test {
systemProperty("java.awt.headless", "true")
useJUnitPlatform()
workingDir = file("build/test")
workingDir.mkdirs()
Expand Down
13 changes: 9 additions & 4 deletions app/src/processing/app/ui/PDEWelcome.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import processing.app.*
import processing.app.api.Contributions.ExamplesList.Companion.listAllExamples
import processing.app.api.Sketch.Companion.Sketch
import processing.app.ui.theme.*
import java.awt.GraphicsEnvironment
import java.io.File
import kotlin.io.path.Path
import kotlin.io.path.exists
Expand Down Expand Up @@ -554,10 +555,14 @@ fun Sketch.card(onOpen: () -> Unit = {}) {
}

fun noBaseWarning() {
Messages.showWarning(
"No Base",
"No Base instance provided, this ui is likely being previewed."
)
if (Base.isCommandLine() || GraphicsEnvironment.isHeadless()) {
System.err.println("No Base instance provided, this ui is likely being previewed");
} else {
Messages.showWarning(
"No Base",
"No Base instance provided, this ui is likely being previewed."
)
}
}

val size = DpSize(970.dp, 600.dp)
Expand Down
2 changes: 1 addition & 1 deletion java/gradle/src/main/kotlin/ProcessingPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class ProcessingPlugin @Inject constructor(private val objectFactory: ObjectFact
val processingVersion = project.findProperty("processing.version") as String?
?: javaClass.classLoader.getResourceAsStream("version.properties")?.use { stream ->
java.util.Properties().apply { load(stream) }.getProperty("version")
} ?: "4.3.4"
}?.takeIf { it != "unspecified" } ?: "4.5.5"
val processingGroup = project.findProperty("processing.group") as String? ?: "org.processing"
val workingDir = project.findProperty("processing.workingDir") as String?
val debugPort = project.findProperty("processing.debugPort") as String?
Expand Down
Loading