Breaking Change: Remove @primer/view-components imports and dependency #2789
Merged
Breaking Change: Remove @primer/view-components imports and dependency #2789
Conversation
🦋 Changeset detectedLatest commit: 9d96055 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This removes the
@primer/view-componentsdependency from the project. This was added when we were moving the styles away from primer/css to primer/view_components to more tightly integrate with markup. The same styles will exist but users will be encouraged to use the new package.What approach did you choose and why?
Search and build
What should reviewers focus on?
What sort of info should I put in the readme to tell folks of this change?
Can these changes ship as is?
Need to verify integration in dotcom before merging