feat: update all fixtures and custom parsers to match#713
Conversation
This patch changes how fixtures are stored. Previously, a fixture's folder identified its domain and its filename identified when it was fetched. This has been changed so that the filename indicates the domain and the modified time of the file indicates how recently it was fetched. A fixture's filename can optionally include a modifier to distinguish between two different page types on the same domain, for example. Also included here are changes to the update-fixture script, both to accomodate the new filename scheme as well as to actually update all fixtures. The functionality for running automatically and opening PRs has been removed but will likely be reintroduced. Finally, all fixtures have been updated.
sdoire
force-pushed
the
fixture-and-custom-extractor-updates
branch
from
69f79b0 to
9dec49e
Compare
|
wondering how i can help you close this ticket so we can move onto the second half of the PR? |
|
@flbn Thanks for finding that issue with the .DS_Store! I could use a second set of eyes to do a review of the PR and do a formal approval (if it looks OK to you, of course). I know it's a lot to review, but it's mostly just updated fixtures, alongside updates of custom parsers and their related unit tests. If you have the bandwidth to take a review on, that would be amazing, but I totally get it if you have too much other stuff going on! |
|
can definitely give it a look over! |
flbn
left a comment
flbn
left a comment
There was a problem hiding this comment.
LGTM, some minor nits and one file that appears to be unused but i'd say this has had a pretty thorough look over 😅 😅
|
the name of the file |
|
all references to deleted files were removed 👍 |
|
all references to files that were renamed are correctly referenced to 👍 |
|
all files added are referenced in their respective extractors/tests 👍 |
This is showing up as being changed to
|
ahh yes, that's what i meant! the file |
Ah, I see now! That unused fixture has been removed. Thanks! |
3 participants
This PR includes the majority of changes from the original move-fixtures PR. It includes everything but the changes to the scripts, which will be done in a future PR. From the original PR:
"This patch changes how fixtures are stored. Previously, a fixture's folder identified its domain and its filename identified when it was fetched. This has been changed so that the filename indicates the domain and the modified time of the file indicates how recently it was fetched. A fixture's filename can optionally include a modifier to distinguish between two different page types on the same domain, for example.
Finally, all fixtures have been updated."
In addition, the updating of fixtures exposed that a number of custom extractors are now out of sync with the current website layouts for their domains, so all of those have been updated so that the custom extractor unit tests are now passing again.