Refactor legend draw to make input/output and optional arguments clear#5579
Merged
Conversation
alexcjohnson
approved these changes
Apr 6, 2021
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
Looks like a nice improvement. Personally I don't see the point of the extra level of indirection (draw -> _draw) but if you prefer it fine. 💃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4620 reused
legend.drawto displayunifiedhovers which is great improvement.But with an unresolved #4620 (comment) it is now difficult to understand what exactly is going on with the optional argument (
opts) passing todrawfunction and downstream.Also
optsis in fact essential (not optional) to most functions inlegend.drawwhile different sizes are computed and stashed into this object (with the intent IN & OUT).This PR is an attempt to address these internal issues before more progress on legends and unified hovers.
@plotly/plotly_js