Implement connectGaps - #361
Merged
Merged
Conversation
mikolalysenko
force-pushed
the
connect-gaps
branch
from
March 26, 2016 00:14
78a0a85 to
a4c4e0d
Compare
Contributor
Author
|
Sorry for the messy commit history. I merged in the middle which screwed up the rebase. |
Contributor
|
Ref commit in |
| plots['connectgaps'] = require('@mocks/gl3d_scatter3d-connectgaps.json'); | ||
| plots['tet'] = require('@mocks/gl3d_tet.json'); | ||
| plots['surface_intensity'] = require('@mocks/gl3d_surface_intensity.json'); | ||
| plots['connectgaps'] = require('@mocks/gl3d_scatter3d-connectgaps.json'); |
Contributor
There was a problem hiding this comment.
and this line should be:
plots['scatter3d-connectgaps'] = require('@mocks/gl3d_scatter3d-connectgaps.json');so that the corresponding image baseline is displayed properly.
Contributor
Author
There was a problem hiding this comment.
whoops! that screwed up when I rebased
Contributor
|
@mikolalysenko Looking good. Thanks for doing this 🍻 We'll merge this in as soon as the minor edits ⏫ are done. |
Contributor
|
nicely done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #281
For example, the following data:
Would produce the following plot:
Gaps in line plots are implemented by inserting a pair of degenerate triangles into the triangle strip