Fixes components to remount when passed from a parent object

[BSd3v]

fixes #3330

fixes issue where components wouldnt remount when passed as a children prop
eg:

import dash_mantine_components as dmc
from dash import Dash, Input, Output, State, no_update, html
from dash_ag_grid import AgGrid
app = Dash()

test = [
    AgGrid(
        id="ag-grid",
        rowData=[
            {"number": 1, "text": "a"},
        ],
        columnDefs=[
            {"field": "number", "filter": "agNumberColumnFilter"},
            {"field": "text", "filter": "agTextColumnFilter"},
        ]
    )
]

app.layout = dmc.MantineProvider(
    [
        html.Div(
            test,
        id='data-entry'
        ),
        dmc.Button('reload layout', id='reload-btn'),
    ],
    id="mantine-provider",
    defaultColorScheme="auto",
)

@app.callback(
    Output('data-entry', 'children'),
    Input('reload-btn', 'n_clicks'),
)
def reload_data(n_clicks):
    if n_clicks:
        return test
    return no_update

if __name__ == "__main__":
    app.run(debug=True)

Running this in the current dash will result in the component keeping some state even though it should technically be unmounted and remounted.

[AnnMarieW]

I tried this and confirmed that it fixes the example app from #3497

[T4rk1n]

💃

[T4rk1n]

The redraw test show one less redraw after a click that might be a regression.

[BSd3v]

Yeah, I wasn't sure how this would perform with specifically that instance.

[AnnMarieW]

Do you think some apps are relying on the current behavior of holding the state, and this might be considered a breaking change?

[T4rk1n]

Do you think some apps are relying on the current behavior of holding the state, and this might be considered a breaking change?

Yes it might effect apps that relies on keeping state even if the content is updated but it's expected to be the same component (with same id), it would reset to what is given back, which might be the correct behavior since it's a new component from the callback. Kind of an undocumented behavior and it's not tested beside the redraw component.

[safroze-plotly]

The fix doesn't work for this app (shared by DE client):

Workaround is to pass id to the layout

import dash
from dash import Input, Output, dcc, html

app = dash.Dash(__name__, prevent_initial_callbacks=True)


def layout_1():
    return dcc.Tabs(
        # id="tabs",  # NOTE: adding id somehow fixes the issue, same for layout_2
        value="tab1",
        children=[
            dcc.Tab(
                html.H2("First step is to switch to the next tab"),
                value="tab1",
                label="Click on next tab =>",
            ),
            dcc.Tab(
                html.H2("Now click on 'Layout 2' or 'Layout 3' button"),
                value="tab2",
                label="Click on me!",
            ),
        ],
    )


def layout_2():
    return html.Div(
        [
            html.H2("Click anywhere inside the red rectangle to see the issue"),
            html.Button("Button", style={"backgroundColor": "green", "padding": "50px"}),
            html.P(
                "Explenation: this Div inside container is replaced with dcc.Tabs after clicking"
            ),
        ]
    )


def layout_3():
    return dcc.Tabs(
        value="tab1",
        children=[
            dcc.Tab(
                html.H2("After clicking on this text last tab will disappear"),
                value="tab1",
                label="Tab 1",
            ),
            # NOTE: commenting the below tabs and repeating the steps will get you an error
            dcc.Tab("1", label="Tab 2"),
            dcc.Tab("2", label="Tab 3"),
        ],
    )


app.layout = html.Div(
    [
        html.H1("Dash bug showcase"),
        html.Button("Layout 1", id="button-1"),
        html.Button("Layout 2", id="button-2", style={"marginLeft": "10px"}),
        html.Button("Layout 3", id="button-3", style={"marginLeft": "10px"}),
        html.P(
            layout_1(),
            id="layout",
            style={"padding": "20px", "border": "2px dashed red"},
        ),
    ]
)


@app.callback(
    Output("layout", "children"),
    Input("button-1", "n_clicks"),
    Input("button-2", "n_clicks"),
    Input("button-3", "n_clicks"),
)
def update_output(_1, _2, _3):
    if dash.ctx.triggered_id == "button-1":
        return layout_1()

    if dash.ctx.triggered_id == "button-2":
        return layout_2()

    if dash.ctx.triggered_id == "button-3":
        return layout_3()


if __name__ == "__main__":
    app.run(debug=True)

[AnnMarieW]

@BSd3v - thanks for the update!
How is your latest commit differ from #3497?

[BSd3v]

While it was correct in theory, it assumed that children was the only time that you would need to reset the hashes. This is not the case for other children like props.

Children should rerender and descendents as well when passed from a parent. This was happening, however when there was a change to the state it was resetting due to the redux state. This now resets all descendant hashes so that there isn't a conflict with the hashed props interfering.

The mentioned PR also would do nothing to the react state, so the component reacting to initial load would not be the same. Some issues with components having async data would clear values when they would leave the data empty on original render. AG Grid would also encounter this.

[AnnMarieW]

This PR would also fix an issue reported on the forum: https://community.plotly.com/t/dropdowns-and-dynamic-options-in-dash-4-0-0/96416/5

There is a bug when updating dropdown options in a callback where the label is a component. I ran the sample app provided and the error does not happen when running with the build in this PR.

[AnnMarieW]

@CNFeffery

Could you please try the build in this PR to see if this bug fix affects performance in fac components?

[AnnMarieW]

Note also that the app above in #3570 (comment) works for me in the latest build. @safroze-plotly would you like to verify?

[CNFeffery]

@CNFeffery

Could you please try the build in this PR to see if this bug fix affects performance in fac components?

@AnnMarieW Based on the latest version of the current pr, I did not find any performance issues in the fac component library.