Skip to content

Remove the PCH file and ensure macros are defined before using - #556

Merged
bolsinga merged 3 commits into
pinterest:masterfrom
bolsinga:RemovePCHFile
Jul 2, 2020
Merged

Remove the PCH file and ensure macros are defined before using#556
bolsinga merged 3 commits into
pinterest:masterfrom
bolsinga:RemovePCHFile

Conversation

@bolsinga

@bolsinga bolsinga commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@bolsinga
bolsinga requested a review from garrettmoon July 2, 2020 20:02

@garrettmoon garrettmoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the Availability import need to go into macros?

@bolsinga

bolsinga commented Jul 2, 2020

Copy link
Copy Markdown
Contributor Author

Does the Availability import need to go into macros?

Good Q. I just had it import <Foundation/Foundation.h> to get it all settled.

@bolsinga
bolsinga merged commit 50cb82d into pinterest:master Jul 2, 2020
@bolsinga
bolsinga deleted the RemovePCHFile branch July 2, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants