Fixed a bug where using PINRemoteImageBasicCache would cause images to be decoded on the main thread. - #457
Merged
Conversation
…o be decoded on the main thread. PINRemoteImageBasicCache disk-cache methods are now no-op.
garrettmoon
approved these changes
May 3, 2018
garrettmoon
left a comment
garrettmoon
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, thank you!
Collaborator
|
Thanks so much for reporting and fixing @kgaidis ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue reference: #451
cancelTaskWithUUID:documentation to say disk cache, and not memory cache.Feel free to (of course) to pick on anything that seems weird. One decision that may feel odd is that I left the global-queue code in
objectFromDiskForKey:completion:. My thought-process was to leave the code functioning as it did before as to not cause any unknown side effects. In this case, the completionHandler will continue to return from a global queue (as before), but it will just always return a nil forobject, instead of just sometimes.