Skip to content

Added property events reflection extension for UI\Form - #38

Closed
adaamz wants to merge 1 commit into
phpstan:masterfrom
adaamz:events
Closed

Added property events reflection extension for UI\Form#38
adaamz wants to merge 1 commit into
phpstan:masterfrom
adaamz:events

Conversation

@adaamz

@adaamz adaamz commented Mar 15, 2019

Copy link
Copy Markdown
Contributor

Hi,
I added specific callable types for events (right now only for Form, I can continue on others if we agree) - so phpstan can detect more bugs like this

$form->onSuccess[] = function(SubmitButton $button): void {}

Is this solution viable or we should try to change nette/forms library?
nette/forms#216

@adaamz

adaamz commented May 12, 2019

Copy link
Copy Markdown
Contributor Author

pr in nette/forms was merged so we do not need this anymore

@adaamz adaamz closed this May 12, 2019
@adaamz
adaamz deleted the events branch May 12, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant