Fix #413 - Adding guard checks before checking keyword#414
Fix #413 - Adding guard checks before checking keyword#414williamdes merged 1 commit intophpmyadmin:masterfrom
Conversation
Signed-off-by: Fawzi Abdulfattah <iifawzie@gmail.com>
Codecov ReportBase: 97.25% // Head: 97.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #414 +/- ##
=========================================
Coverage 97.25% 97.25%
- Complexity 2194 2196 +2
=========================================
Files 68 68
Lines 5057 5057
=========================================
Hits 4918 4918
Misses 139 139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
williamdes
left a comment
There was a problem hiding this comment.
Thank you, that was incredibly fast!
Pull-request: #414 Signed-off-by: William Desportes <williamdes@wdes.fr>
|
phpstan had found it 👻 😄 |
|
Hahaha, yes, we should have checked that |
|
@williamdes , I've added iifawzi@0cfa6a1, can you manage to get this merged? or should I create another PR? Added the tests to the provider, I've missed that. and renamed them to follow our namings way |
I pushed it as 1a5b97c 🚀 |
Hi, this's fixing #413
fixes #413
Signed-off-by: Fawzi Abdulfattah iifawzie@gmail.com