Closed
Conversation
--with-toolset=clang was missing.
iluuu1994
force-pushed
the
fix-windows-clang-on-8.5
branch
from
b8528fd to
759c7b0
Compare
Contributor
|
Seems like not compatible because the -Werror was already set in 8.5. I thought it was from 8.4 but was mistaken. Probably easier to bump the test to >= 8.6, the clang advantage is minimal on 8.5 anyways, the majority of it lies in the tailcall vm which was requested not to land in 8.5. |
Member
Author
|
Okay. Done here: 046ffa2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--with-toolset=clang was missing.