Skip to content

ext/mysqli: Throw error when mysql_stmt_data_seek cannot be executed #10419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamil-tekiela merged 4 commits into from
Apr 21, 2026
Merged

ext/mysqli: Throw error when mysql_stmt_data_seek cannot be executed #10419

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23d4dc1
Throw error when mysql_stmt_data_seek fails
kamil-tekiela Jan 22, 2023
89b3439
Check ahead of time
kamil-tekiela Apr 21, 2026
418a954
Add function name to the message
kamil-tekiela Apr 21, 2026
618cd41
Fix test case
kamil-tekiela Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/mysqli/mysqli_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1488,6 +1488,11 @@ PHP_FUNCTION(mysqli_stmt_data_seek)

MYSQLI_FETCH_RESOURCE_STMT(stmt, mysql_stmt, MYSQLI_STATUS_VALID);

if (!stmt->stmt->data || !stmt->stmt->data->result || !stmt->stmt->data->result->stored_data) {
zend_throw_error(NULL, "No result set associated with the statement");
RETURN_THROWS();
}

mysql_stmt_data_seek(stmt->stmt, offset);
}
/* }}} */
Expand Down
6 changes: 6 additions & 0 deletions ext/mysqli/tests/mysqli_stmt_data_seek.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ require_once 'skipifconnectfailure.inc';
if (true !== ($tmp = mysqli_stmt_execute($stmt)))
printf("[006] Expecting boolean/true, got %s/%s\n", gettype($tmp), $tmp);

try {
mysqli_stmt_data_seek($stmt, 1);
} catch (Error $exception) {
echo $exception->getMessage() . "\n";
}

$id = null;
if (!mysqli_stmt_bind_result($stmt, $id))
Expand Down Expand Up @@ -82,6 +87,7 @@ require_once 'skipifconnectfailure.inc';
?>
--EXPECT--
mysqli_stmt object is not fully initialized
No result set associated with the statement
int(3)
int(1)
int(1)
Expand Down
Loading