CI: check the EN-Revision hash of changed files#151
Open
lacatoire wants to merge 1 commit into
Open
Conversation
lacatoire
force-pushed
the
ci/check-en-revision
branch
from
bf33d6c to
9e69863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow that, on every PR, checks that the
EN-Revision:comment of the changed .xml files points to the latest doc-en commit for that file. A missing, wrong, mismatched or outdated hash produces a::errorannotation.The same check already runs on
php/doc-fr(on every PR),php/doc-esandphp/doc-ru:https://github.com/php/doc-fr/blob/master/.github/workflows/check-en-revision.yml
It only needs a checkout of doc-en, no doc-base. To make it warn without blocking the PR, change the final
exit $failtoexit 0.A shared translation toolchain is being built in
php/doc-baseso every language can get these checks from a single place. Until that lands, this workflow is a useful stopgap: it is fully self-contained (doc-en checkout only) and provides the check today.