Skip to content

stream_insert update_only aka stream_update - #3573

Merged
SteffenDE merged 1 commit into
mainfrom
sd-stream_insert_update_only
May 22, 2025
Merged

stream_insert update_only aka stream_update#3573
SteffenDE merged 1 commit into
mainfrom
sd-stream_insert_update_only

Conversation

@SteffenDE

Copy link
Copy Markdown
Member

Fixes #2690.
Relates to: https://elixirforum.com/t/add-stream-update-to-liveview-streams/68107

Work in progress, no tests yet.

Please see the attached links and let's decide if this is something we now want to support.

@SteffenDE
SteffenDE force-pushed the sd-stream_insert_update_only branch from 2ac64d1 to b3f7e83 Compare December 15, 2024 15:42
@SteffenDE

Copy link
Copy Markdown
Member Author

@josevalim let me know if you think that this is worth pursuing now that 1.0 is out.

@josevalim

Copy link
Copy Markdown
Member

Thank you for the ping. My opinion is no longer relevant. You are a more active maintainer of the project than I am, so it is truly your decision. :) Chris may have thoughts!

@lemaster

Copy link
Copy Markdown

Happy New Year everyone. Is there anything I can do to help move this issue along?

@SteffenDE
SteffenDE force-pushed the sd-stream_insert_update_only branch from b3f7e83 to 2dd41b7 Compare February 18, 2025 13:01
@SteffenDE

Copy link
Copy Markdown
Member Author

Hey @lemaster,

you can try out the functionality with

{:phoenix_live_view, github: "phoenixframework/phoenix_live_view", branch: "sd-stream_insert_update_only-assets", override: true}

and give us feedback if it works as you'd expect.

We're currently waiting for feedback from Chris, but if he approves this change it'll move along :)

@lemaster

Copy link
Copy Markdown

I tested it out and it worked as expected. Thanks!

@SteffenDE SteffenDE added this to the v1.1 milestone Mar 26, 2025
@SteffenDE

Copy link
Copy Markdown
Member Author

I'd still like feedback from @chrismccord if he'd rather do stream_update or do it as an option on stream_insert (like the current implementation).

@lemaster

lemaster commented Apr 8, 2025

Copy link
Copy Markdown

Awesome to see it's still in progress. Thanks again. I shall wait patiently.

@lemaster

lemaster commented May 8, 2025

Copy link
Copy Markdown

Is there a chance that this will go out as part of the phoenix 1.8 release?

@SteffenDE

Copy link
Copy Markdown
Member Author

LiveView and Phoenix releases aren’t coupled. I’m planning to talk to Chris at ElixirConf :)

@SteffenDE
SteffenDE force-pushed the sd-stream_insert_update_only branch from 2dd41b7 to a1d0843 Compare May 22, 2025 08:08
@SteffenDE
SteffenDE marked this pull request as ready for review May 22, 2025 08:08
@SteffenDE
SteffenDE merged commit a27a25e into main May 22, 2025
@SteffenDE
SteffenDE deleted the sd-stream_insert_update_only branch May 22, 2025 21:59
@SteffenDE

Copy link
Copy Markdown
Member Author

Will be part of LiveView 1.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating a stream element without inserting

3 participants