Small cleanups in Routes#30
Draft
Potherca wants to merge 5 commits into
Draft
Conversation
- Cleanup "if" statements (remove unneeded, combine consecutive) - Fix dynamic calls to static method - Hardening (make array comparison strict, make json_decode throw, user input type check, add check for constant existence) - Use statements (remove unused, sort alphabetically) - Whitespace fixes (convert all indents to tabs, remove trailing whitespace)
- Use statements (remove unused, sort alphabetically)
- Dead code (remove unused variable) - Fix dynamic call to static method - Use statements (remove unused, sort alphabetically) - Whitespace fixes (convert all indents to tabs, remove trailing whitespace)
- Fix dynamic call to static method - Use statements (sort alphabetically)
- Fix dynamic calls to static method - Dead code (remove unused variable) - Use statements (remove unused, sort alphabetically)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to draft until changes to logic have been removed from commits.
This MR makes minor changes to clean up the Routes classes.
This is part of a first round of minor cleanup before larger changes are made.