Skip to content

fix(DataList): allow keyboard to trigger DataListActions #11974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wise-king-sullyman merged 2 commits into from
Sep 10, 2025
Merged

fix(DataList): allow keyboard to trigger DataListActions #11974

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b3257
fix(DataList): allow keyboard to trigger DataListActions
kmcfaul Aug 25, 2025
07de1b5
fix - ignore menu item events in datalist
kmcfaul Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/react-core/src/components/DataList/DataListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ class DataListItem extends Component<DataListItemProps> {

const onKeyDown = (event: React.KeyboardEvent) => {
if ([KeyTypes.Enter, KeyTypes.Space].includes(event.key)) {
const target: any = event.target;
if (
target.parentNode.classList.contains(styles.dataListItemAction) ||
target.parentNode.classList.contains(styles.dataListItemControl)
) {
// check other event handlers are not present.
return;
}

event.preventDefault();
updateSelectedDataListItem(event, id);
Comment thread
kmcfaul marked this conversation as resolved.
}
Expand Down
Loading