Skip to content

fix(Table): Add hasNoPadding prop to header info button #11089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmcfaul merged 2 commits into from
Sep 30, 2024
Merged

fix(Table): Add hasNoPadding prop to header info button #11089

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3b9cb9
fix(Table): Add hasNoPaddinf prop to header info button
tlabaj Sep 27, 2024
9a15eea
Add hasNoPaddinf prop to header info button without tooltip
tlabaj Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/react-table/src/components/Table/HeaderCellInfoWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export const HeaderCellInfoWrapper: React.FunctionComponent<ColumnHelpWrapperPro
<Tooltip content={info} {...tooltipProps}>
<Button
variant="plain"
hasNoPadding
aria-label={ariaLabel || (typeof info === 'string' && info) || 'More info'}
icon={<HelpIcon />}
/>
Expand All @@ -62,6 +63,7 @@ export const HeaderCellInfoWrapper: React.FunctionComponent<ColumnHelpWrapperPro
<Popover bodyContent={info} {...popoverProps}>
<Button
variant="plain"
hasNoPadding
aria-label={ariaLabel || (typeof info === 'string' && info) || 'More info'}
icon={<HelpIcon />}
/>
Expand Down