feat(helper-text): port <pf-v5-helper-text> to <pf-v6-helper-text> element#3155
Open
adamjohnson wants to merge 5 commits into
Open
feat(helper-text): port <pf-v5-helper-text> to <pf-v6-helper-text> element#3155adamjohnson wants to merge 5 commits into
<pf-v5-helper-text> to <pf-v6-helper-text> element#3155adamjohnson wants to merge 5 commits into
Conversation
🦋 Changeset detectedLatest commit: 205eb07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
<pf-v5-helper-text> to <pf-v6-helper-text> element
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(helper-text): port `<pf-v5-helper-text>` to `<pf-v6-helper-text>` element"
} |
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment has been minimized.
This comment has been minimized.
18 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<pf-v5-helper-text><pf-v5-helper-text>to<pf-v6-helper-text>web component for PatternFly v6variant(default/indeterminate/warning/success/error),has-icon,dynamic, andscreen-reader-textattributes@patternfly/react-icons(rh-ui-minus, rh-ui-warning-fill, rh-ui-check-circle-fill, rh-ui-error-fill)light-dark()CSS fallbacksCloses #3012
Intentional divergences from React
HelperText(container) +HelperTextItem(item) pair; use plain HTML wrappers witharia-livefor groupinghas-iconattribute for opt-in icon display (React auto-shows icons for non-default variants)iconslot replaces React'siconprop (ReactNode → slotted markup)screen-reader-textattribute maps to React'sscreenReaderTextpropdynamicattribute exposes React's internal.pf-m-dynamicCSS modifier classcomponent,isLiveRegion,aria-label) not implemented; users apply these directly on wrapper elements<pf-v5-icon>— uses inline SVG iconsTest plan
npm run testpasseslocalhost:8000screen-reader-textoverrides default announcementscreen-reader-text=""suppresses announcementaria-livecontainer with mixed success/error itemsAssisted-By: Claude