Skip to content

fix(pfe-tools): use WDS plugin for TS redirect instead of koa middleware #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bennypowers wants to merge 2 commits into
base: staging/pfv6
Choose a base branch
from
Open

fix(pfe-tools): use WDS plugin for TS redirect instead of koa middleware #3144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b95cc3
fix(pfe-tools): use WDS plugin for TS redirect instead of koa middleware
bennypowers May 12, 2026
c0b44f9
fix(pfe-tools): redirect .js to .ts only on 404
bennypowers May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions tools/pfe-tools/dev-server/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,21 +88,13 @@ async function cacheBusterMiddleware(ctx: Context, next: () => Promise<any>) {
function liveReloadTsChangesMiddleware(
config: ReturnType<typeof normalizeOptions>,
): Middleware {
/**
* capture group 1:
* Either config.elementsDir or `pfe-core`
* `/`
* **ANY** (_>= 0x_)
* `.js`
*/
const TYPESCRIPT_SOURCES_RE = new RegExp(`(${config.elementsDir}|pfe-core)/.*\\.js`);

return function(ctx, next) {
if (!ctx.path.includes('node_modules') && ctx.path
.match(TYPESCRIPT_SOURCES_RE)) {
return async function(ctx, next) {
await next();
if (ctx.status === 404
&& !ctx.path.includes('node_modules')
&& TYPESCRIPT_SOURCES_RE.test(ctx.path)) {
ctx.redirect(ctx.path.replace('.js', '.ts'));
Comment on lines 91 to 97
Copy link
Copy Markdown
Collaborator

@zeroedin zeroedin May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid but likely no-op.

} else {
return next();
}
Comment on lines +92 to 98
};
}
Expand Down
Loading