Skip to content

Support Metadata in GridFSAdapter - #6660

Merged
dplewis merged 5 commits into
masterfrom
metadata-mongo
May 8, 2020
Merged

Support Metadata in GridFSAdapter#6660
dplewis merged 5 commits into
masterfrom
metadata-mongo

Conversation

@dplewis

@dplewis dplewis commented Apr 30, 2020

Copy link
Copy Markdown
Member
  • Useful for testing in the JS SDK
  • Adds new endpoint to be used with Parse.File.getData
  • Allows file adapters to return tags as well as future data.

dplewis added 4 commits April 30, 2020 02:25
* Useful for testing in the JS SDK
* Adds new endpoint to be used with `Parse.File.getData`
* Allows file adapters to return tags as well as future data.
This reverts commit 7706da1.
@codecov

codecov Bot commented Apr 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #6660 into master will increase coverage by 0.02%.
The diff coverage is 80.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6660      +/-   ##
==========================================
+ Coverage   93.86%   93.88%   +0.02%     
==========================================
  Files         169      169              
  Lines       12009    12028      +19     
==========================================
+ Hits        11272    11293      +21     
+ Misses        737      735       -2     
Impacted Files Coverage Δ
src/Adapters/Files/FilesAdapter.js 100.00% <ø> (ø)
src/Routers/FilesRouter.js 86.06% <71.42%> (+1.24%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 71.64% <90.90%> (+2.78%) ⬆️
src/Controllers/FilesController.js 94.00% <100.00%> (+0.38%) ⬆️
src/RestWrite.js 93.51% <0.00%> (-0.17%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.52% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b150699...9eadb8c. Read the comment docs.

@dplewis
dplewis requested review from acinader and davimacedo May 2, 2020 06:14

@acinader acinader left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread spec/GridFSBucketStorageAdapter.spec.js
@acinader

acinader commented May 3, 2020

Copy link
Copy Markdown
Contributor

@dplewis do you have an access issue with codecov I can help with?

@dplewis

dplewis commented May 5, 2020

Copy link
Copy Markdown
Member Author

@acinader Codecov works now. I'm increasing test coverage here. The coverage diff has nothing to do with this PR. Most likely Prettier

@dplewis
dplewis merged commit 370215a into master May 8, 2020
@dplewis
dplewis deleted the metadata-mongo branch May 8, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants