Skip to content

skip cleanup so we don't erase babel and stuff - #6452

Merged
acinader merged 7 commits into
masterfrom
fix-deploy
Feb 29, 2020
Merged

skip cleanup so we don't erase babel and stuff#6452
acinader merged 7 commits into
masterfrom
fix-deploy

Conversation

@acinader

Copy link
Copy Markdown
Contributor

No description provided.

@acinader
acinader requested a review from dplewis February 28, 2020 23:56

@dplewis dplewis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets see how it goes

@acinader
acinader requested a review from dplewis February 29, 2020 00:08
Comment thread CHANGELOG.md Outdated
@codecov

codecov Bot commented Feb 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #6452 into master will increase coverage by 10.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6452       +/-   ##
===========================================
+ Coverage   83.56%   93.93%   +10.36%     
===========================================
  Files         169      169               
  Lines       11796    11796               
===========================================
+ Hits         9857    11080     +1223     
+ Misses       1939      716     -1223     
Impacted Files Coverage Δ
src/Adapters/Storage/Mongo/MongoTransform.js 88.82% <0.00%> (+0.14%) ⬆️
src/Routers/UsersRouter.js 94.33% <0.00%> (+0.62%) ⬆️
src/Controllers/UserController.js 94.39% <0.00%> (+0.93%) ⬆️
src/Controllers/DatabaseController.js 95.19% <0.00%> (+1.28%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.79% <0.00%> (+1.57%) ⬆️
src/Controllers/FilesController.js 93.61% <0.00%> (+2.12%) ⬆️
src/batch.js 91.83% <0.00%> (+12.24%) ⬆️
src/ParseServerRESTController.js 98.18% <0.00%> (+14.54%) ⬆️
src/Adapters/Storage/Postgres/PostgresClient.js 86.66% <0.00%> (+80.00%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.72% <0.00%> (+94.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5c306...52463f4. Read the comment docs.

@acinader
acinader requested a review from dplewis February 29, 2020 00:16

@TomWFox TomWFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure #6439 is a breaking change, seems it just adds an error message to explain that default fields cannot be protected.

@davimacedo

Copy link
Copy Markdown
Member

I don't think it is since no tests were changed. I understand that the error already existed. We are only improving the feedback.

@acinader

Copy link
Copy Markdown
Contributor Author

got it. changing.

@acinader
acinader merged commit cd06a02 into master Feb 29, 2020
@acinader

acinader commented Feb 29, 2020

Copy link
Copy Markdown
Contributor Author

@dplewis @davimacedo boo. Travis still not happy.

I won't be able to look at this weekend, but I can definitely get on it on Monday.

https://travis-ci.org/parse-community/parse-server/jobs/656523701?utm_medium=notification&utm_source=github_status

@TomWFox TomWFox added the release label Mar 1, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* skip cleanup so we don't erase babel and stuff

* skip cleanup the right way!

* Add change log and bump version

* include one more commit

* remove breaking change from non breaking change.

Co-authored-by: Diamond Lewis <findlewis@gmail.com>
@TomWFox
TomWFox deleted the fix-deploy branch April 3, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants