Update PostgresStorageAdapter.js - #6275
Conversation
Improving use of the `await.async` notation in relation to `pg-promise`, and in general.
Correcting some results.
Codecov Report
@@ Coverage Diff @@
## master #6275 +/- ##
==========================================
+ Coverage 93.81% 93.82% +<.01%
==========================================
Files 169 169
Lines 11564 11564
==========================================
+ Hits 10849 10850 +1
+ Misses 715 714 -1
Continue to review full report at Codecov.
|
|
@vitaly-t Thanks for the PR, it looks good to me. Is there a reason why this is an improvement? I always use async / await like this. |
|
@dplewis The initial idea was to improve methods such as Methods such as those, resolve with |
|
Oh I see, you are right they shouldn't return. The adapter should conform to the StorageAdapter |
* Update PostgresStorageAdapter.js Improving use of the `await.async` notation in relation to `pg-promise`, and in general. * Update PostgresStorageAdapter.js * Update PostgresStorageAdapter.js Correcting some results. * Update PostgresStorageAdapter.js
Improving use of the
await/asyncnotation in relation topg-promise, and in general.