Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions spec/rest.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1390,6 +1390,54 @@ describe('read-only masterKey', () => {
expect(res.data.error).toBe('Permission denied');
}
});

it('should expose isReadOnly in Cloud Function request when using readOnlyMasterKey', async () => {
let receivedMaster;
let receivedIsReadOnly;
Parse.Cloud.define('checkReadOnly', req => {
receivedMaster = req.master;
receivedIsReadOnly = req.isReadOnly;
return 'ok';
});

await request({
method: 'POST',
url: `${Parse.serverURL}/functions/checkReadOnly`,
headers: {
'X-Parse-Application-Id': Parse.applicationId,
'X-Parse-Master-Key': 'read-only-test',
'Content-Type': 'application/json',
},
body: {},
});

expect(receivedMaster).toBe(true);
expect(receivedIsReadOnly).toBe(true);
});

it('should not set isReadOnly in Cloud Function request when using masterKey', async () => {
let receivedMaster;
let receivedIsReadOnly;
Parse.Cloud.define('checkNotReadOnly', req => {
receivedMaster = req.master;
receivedIsReadOnly = req.isReadOnly;
return 'ok';
});

await request({
method: 'POST',
url: `${Parse.serverURL}/functions/checkNotReadOnly`,
headers: {
'X-Parse-Application-Id': Parse.applicationId,
'X-Parse-Master-Key': Parse.masterKey,
'Content-Type': 'application/json',
},
body: {},
});

expect(receivedMaster).toBe(true);
expect(receivedIsReadOnly).toBe(false);
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
});

describe('rest context', () => {
Expand Down
1 change: 1 addition & 0 deletions src/Routers/FunctionsRouter.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ export class FunctionsRouter extends PromiseRouter {
params: params,
config: req.config,
master: req.auth && req.auth.isMaster,
isReadOnly: !!(req.auth && req.auth.isReadOnly),
user: req.auth && req.auth.user,
installationId: req.info.installationId,
log: req.config.loggerController,
Expand Down
11 changes: 11 additions & 0 deletions src/triggers.js
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ export function getRequestObject(
triggerName: triggerType,
object: parseObject,
master: false,
isReadOnly: false,
log: config.loggerController,
headers: config.headers,
ip: config.ip,
Expand Down Expand Up @@ -301,6 +302,9 @@ export function getRequestObject(
if (auth.isMaster) {
request['master'] = true;
}
if (auth.isReadOnly) {
request['isReadOnly'] = true;
}
if (auth.user) {
request['user'] = auth.user;
}
Expand All @@ -317,6 +321,7 @@ export function getRequestQueryObject(triggerType, auth, query, count, config, c
triggerName: triggerType,
query,
master: false,
isReadOnly: false,
count,
log: config.loggerController,
isGet,
Expand All @@ -332,6 +337,9 @@ export function getRequestQueryObject(triggerType, auth, query, count, config, c
if (auth.isMaster) {
request['master'] = true;
}
if (auth.isReadOnly) {
request['isReadOnly'] = true;
}
if (auth.user) {
request['user'] = auth.user;
}
Expand Down Expand Up @@ -1031,6 +1039,9 @@ export function getRequestFileObject(triggerType, auth, fileObject, config) {
if (auth.isMaster) {
request['master'] = true;
}
if (auth.isReadOnly) {
request['isReadOnly'] = true;
}
if (auth.user) {
request['user'] = auth.user;
}
Expand Down
Loading