Add support for Cargo workspaces in Rust integration - #1488
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1488 +/- ##
==========================================
+ Coverage 86.41% 90.82% +4.41%
==========================================
Files 80 80
Lines 4585 6248 +1663
==========================================
+ Hits 3962 5675 +1713
+ Misses 623 573 -50
Continue to review full report at Codecov.
|
devongovett
approved these changes
Jun 5, 2018
Member
|
Thanks! |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the PR Parcel tries to infer the output directory for a cargo build in a less flexible way. However, since the project structure of Cargo projects that make use of workspaces feature is slightly different from the normal one, that fails.
This PR uses the
cargo metadatacommand to infer the correct target directory, which is should be fairly robust.