BUGS-6563: Add primary key if necessary - #265
Merged
Merged
Conversation
pwtyler
requested changes
Sep 19, 2023
pwtyler
left a comment
pwtyler
left a comment
Member
There was a problem hiding this comment.
- lacking tests is a concern (discussed in slack)
- Document new behavior in READMEs
- Update changelog(s) in READMEs
- Add Upgrade Notice informing of the new behavior to README.txt
- Major version bump should be included in this PR
added 24 commits
September 21, 2023 09:51
added 10 commits
September 27, 2023 16:08
Contributor
Author
|
@pwtyler Unfortunately without the composer update, the PHP Unit tests fail on the nightly build:
|
pwtyler
reviewed
Sep 28, 2023
pwtyler
reviewed
Sep 29, 2023
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
jazzsequence
requested changes
Oct 2, 2023
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
Co-authored-by: Chris Reynolds <chris.reynolds@pantheon.io>
pwtyler
approved these changes
Oct 4, 2023
Co-authored-by: Phil Tyler <phil.tyler@pantheon.io>
jazzsequence
approved these changes
Oct 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers who installed the plugin before version 1.2.2 have tables which are missing a Primary key. This PR adds a new WP CLI command which allows them to rectify the issue safely, and then either finalize the changes or roll them back easily.