Skip to content

deprecate storage_class attributes - #3169

Merged
davidism merged 1 commit into
mainfrom
deprecate-storage-classes
May 5, 2026
Merged

deprecate storage_class attributes#3169
davidism merged 1 commit into
mainfrom
deprecate-storage-classes

Conversation

@davidism

@davidism davidism commented May 5, 2026

Copy link
Copy Markdown
Member

Request.parameter_storage_class was used for args, form, and files; dict_storage_class was used for cookies; and list_storage_class was used for access_route. parse_cookie, parse_form_data, and FormDataParser took a cls parameter.

Documentation, old issues, and code search suggest these were previously used to set OrderedMultiDict. But that's been removed, as Python's dict has guaranteed order for a long time.

There's also a suggestion they were used to turn off the "immutable" part, but Request data is immutable and typing should reflect that; an app can do MultiDict(request.form) if they need to modify data for some other use.

These no longer appear to have any use, and there's little evidence they were in use previously. Removing these makes the code simpler to maintain. It will also improve the static typing.

@davidism davidism added this to the 3.2.0 milestone May 5, 2026
@davidism
davidism merged commit 1b00618 into main May 5, 2026
12 checks passed
@davidism
davidism deleted the deprecate-storage-classes branch May 5, 2026 21:07
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant