deprecate storage_class attributes - #3169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request.parameter_storage_classwas used forargs,form, andfiles;dict_storage_classwas used forcookies; andlist_storage_classwas used foraccess_route.parse_cookie,parse_form_data, andFormDataParsertook aclsparameter.Documentation, old issues, and code search suggest these were previously used to set
OrderedMultiDict. But that's been removed, as Python'sdicthas guaranteed order for a long time.There's also a suggestion they were used to turn off the "immutable" part, but
Requestdata is immutable and typing should reflect that; an app can doMultiDict(request.form)if they need to modify data for some other use.These no longer appear to have any use, and there's little evidence they were in use previously. Removing these makes the code simpler to maintain. It will also improve the static typing.