Re-use existing regex for whitespace detection#1368
Merged
davidism merged 1 commit intopallets:mainfrom Mar 8, 2022
Merged
Conversation
Member
|
Fairly sure that comment/code you removed was due to a previous PR. Can you check to see if you can find that PR so we can make sure we're not missing something? |
Contributor
Author
|
You just added comments, some variables and reformatted in 37249c0 There was some change in dbbd082, but this PR doesn't reintroduce the bug in the linked issue (and I suppose there is a test for that somewhere). The regex was introduced in 7d00a40, I don't know what was going on there before that. So I don't think I'm reverting some old PR. |
Member
Whitespace regex could also detect newlines, but since we're only matching the part from last newline, it's safer (and more readable) to use it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less regexes = win.
Whitespace regex could also detect newlines, but since we're only
matching the part from last newline, it's safer (and more readable)
to use it here.
Checklist:
pre-commithooks and fix any issues.pytestandtox, no tests failed.