fix: accept day-of-week 7 (Sunday) in the seconds and year cron forms - #263
Open
nikolauspschuetz wants to merge 1 commit into
Open
fix: accept day-of-week 7 (Sunday) in the seconds and year cron forms#263nikolauspschuetz wants to merge 1 commit into
nikolauspschuetz wants to merge 1 commit into
Conversation
nikolauspschuetz
force-pushed
the
fix-dow7-second-year-forms
branch
from
August 16, 2026 16:11
f4e895c to
ee823d6
Compare
nikolauspschuetz
marked this pull request as ready for review
August 23, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7is a standard alias for Sunday (0), and croniter accepts it in the classic 5-field form.value_aliasskipped the7 -> 0conversion in the 6-field (seconds) and 7-field (year) forms, so7was rejected there as out of range:The guard is there to keep rejecting
0as a day/month in those forms; day-of-week was swept into it. Dropping day-of-week from the two branches makes7 -> Sundaywork in every form while leaving the month/day0rejection unchanged. Regression test added; full suite green.