Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

feat: add caching system - #29

Closed
wizard-28 wants to merge 2 commits into
developfrom
feat/cache
Closed

feat: add caching system#29
wizard-28 wants to merge 2 commits into
developfrom
feat/cache

Conversation

@wizard-28

@wizard-28 wizard-28 commented Mar 31, 2022

Copy link
Copy Markdown
Member

Closes #28

Progress

Repository (Source) table

  • URL
  • Last update
  • Preference order

Pacscript table

  • Name
  • Homepage
  • Repology
  • repository
  • Installed size
  • Download Size
  • Description
  • License
  • version
  • maintainer
  • Auto/Manual
  • APT dependencies
  • Pacstall dependencies
  • APT optional dependencies
  • Pacstall optional dependencies
  • is_installed

@wizard-28 wizard-28 added enhancement New feature or request cache Related to the caching system labels Mar 31, 2022
@wizard-28 wizard-28 self-assigned this Mar 31, 2022
@codecov

codecov Bot commented Mar 31, 2022

Copy link
Copy Markdown

Codecov Report

Merging #29 (fc25a61) into develop (be21882) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           develop       #29    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            3         5     +2     
  Lines           62       168   +106     
==========================================
+ Hits            62       168   +106     
Impacted Files Coverage Δ
libpacstall/cache.py 100.00% <100.00%> (ø)
tests/test_cache.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@wizard-28
wizard-28 force-pushed the feat/cache branch 4 times, most recently from 4f24d1e to 24e7891 Compare April 2, 2022 15:37
@wizard-28
wizard-28 force-pushed the feat/cache branch 3 times, most recently from 9d901c4 to 5f4d9ef Compare May 27, 2022 13:53
@wizard-28
wizard-28 marked this pull request as ready for review May 27, 2022 15:11
@wizard-28
wizard-28 requested a review from D-Brox May 27, 2022 15:11
@Elsie19

Elsie19 commented May 30, 2022

Copy link
Copy Markdown
Member

Since a PKGBUILD will be compatible with 2.0.0 Pacscript, should this caching system also log what license a package is?

Also, other keys should probably be added (reference).

@Elsie19 Elsie19 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check codacy also

@wizard-28

Copy link
Copy Markdown
Member Author

Check codacy also

Checked those, nothing can be done. I'll exclude the test directory from Codacy tests.

@wizard-28

Copy link
Copy Markdown
Member Author

Closing this as there will be a Rust implementation.

@wizard-28 wizard-28 closed this Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cache Related to the caching system enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a flexible cache system

3 participants