Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Sync page title and h1 tag - #5005

Merged
kulmann merged 2 commits into
masterfrom
sync-page-title-and-h1-tag
Apr 24, 2021
Merged

Sync page title and h1 tag#5005
kulmann merged 2 commits into
masterfrom
sync-page-title-and-h1-tag

Conversation

@kulmann

@kulmann kulmann commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

Description

The last PR was not paying attention to actual page titles. With this PR the h1 tags reflect the relevant bit of the page title.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Apr 23, 2021

@fschade fschade left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGMT

@pascalwengerter pascalwengerter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@kulmann
kulmann force-pushed the sync-page-title-and-h1-tag branch from e3005cd to 4cf5dee Compare April 23, 2021 17:12
@kulmann
kulmann merged commit 3798385 into master Apr 24, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the sync-page-title-and-h1-tag branch April 24, 2021 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semantically correct headlines

3 participants