This repository was archived by the owner on Jul 14, 2026. It is now read-only.
A11y improvements for meta attributes - #4811
Merged
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
|
AlexAndBear
changed the title
AlexAndBear
marked this pull request as ready for review
March 16, 2021 11:34
9 tasks
AlexAndBear
force-pushed
the
enhanche-meta-attributs
branch
from
March 16, 2021 12:18
dee5c6b to
e66d544
Compare
pascalwengerter
approved these changes
Mar 16, 2021
kulmann
suggested changes
Mar 16, 2021
AlexAndBear
force-pushed
the
enhanche-meta-attributs
branch
from
March 16, 2021 13:46
e66d544 to
ba2c248
Compare
kulmann
approved these changes
Mar 16, 2021
kulmann
left a comment
kulmann
left a comment
Contributor
There was a problem hiding this comment.
Nice 😍
Could you rebase please? Might be that the failing test pipeline will be fixed by that.
Contributor
Author
|
already up to date .... |
Contributor
ok, thanks. Then we need to have a look at the failing test. |
Contributor
Author
|
@kulmann restarted ci - green now 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: