Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

show error message if config could not be parsed - #4749

Merged
individual-it merged 1 commit into
masterfrom
invalidConfig
Feb 16, 2021
Merged

show error message if config could not be parsed#4749
individual-it merged 1 commit into
masterfrom
invalidConfig

Conversation

@individual-it

Copy link
Copy Markdown
Member

Description

Show a nice error message not only when the config is missing but also when the config could not be parsed

Related Issue

Motivation and Context

make it easier for the user to find our what is wrong if an error was made writing the config

How Has This Been Tested?

  • unit tests
  • load the app with missing config
  • load the app with an ivalid config

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@LukasHirt LukasHirt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🚀 I'm loving to see first unit tests coming as well!

@owncloud owncloud deleted a comment from update-docs Bot Feb 16, 2021
@individual-it
individual-it merged commit 9924a9c into master Feb 16, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the invalidConfig branch February 16, 2021 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] blank page with trivial syntax errors in config.json

2 participants