This repository was archived by the owner on Jul 14, 2026. It is now read-only.
Update ODS to 2.1.2 - #4594
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
kulmann
force-pushed
the
ods-table-component
branch
2 times, most recently
from
January 19, 2021 13:42
4b980fb to
fdaefc0
Compare
LukasHirt
reviewed
Jan 20, 2021
kulmann
force-pushed
the
ods-table-component
branch
2 times, most recently
from
January 27, 2021 12:43
36258ed to
34a2d13
Compare
kulmann
force-pushed
the
ods-table-component
branch
from
January 29, 2021 17:54
4c2fe5a to
12089ef
Compare
Contributor
Author
|
Rebased after #4671 got merged |
kulmann
marked this pull request as ready for review
January 29, 2021 17:55
Contributor
Author
|
Finally green CI. Please re-review @LukasHirt 😃 |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates ODS to 2.1.2
We needed to do some fixes because of changed things in ODS:
oc-tableis nowoc-table-simpleoc-stardoesn't exist anymoremomenthas been removed from ODS. We want to useluxonnow instead - replacing first occurrence of moment in this PR (because it was used from ODS, which doesn't provide moment anymore), others will follow in a separate one.Types of changes
Checklist: