Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

Bring back oc10 app release - #4427

Merged
LukasHirt merged 10 commits into
masterfrom
oc10-app
Dec 8, 2020
Merged

Bring back oc10 app release#4427
LukasHirt merged 10 commits into
masterfrom
oc10-app

Conversation

@LukasHirt

@LukasHirt LukasHirt commented Dec 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Add build steps to makefile to create a phoenix-app.tar.gz, create appinf, change icons to reflect the ones in app switcher and add docs on how to deploy the app.

@LukasHirt LukasHirt self-assigned this Dec 7, 2020
@update-docs

This comment has been minimized.

Sign in to view
@LukasHirt
LukasHirt marked this pull request as ready for review December 7, 2020 14:49
@LukasHirt
LukasHirt requested a review from micbar December 7, 2020 14:49
LukasHirt
LukasHirt commented Dec 7, 2020
View reviewed changes
Comment thread docs/deployments/oc10-app.md
Comment thread appinfo/info.xml
@LukasHirt
LukasHirt requested a review from kulmann December 7, 2020 14:52
phil-davis
phil-davis reviewed Dec 7, 2020
View reviewed changes
Comment thread docs/deployments/oc10-app.md Outdated
Comment thread docs/deployments/oc10-app.md Outdated
Comment thread docs/deployments/oc10-app.md Outdated
pmaier1
pmaier1 approved these changes Dec 7, 2020
View reviewed changes

@pmaier1 pmaier1 left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

Will check info.xml at a later point before the release.

LukasHirt
LukasHirt commented Dec 8, 2020
View reviewed changes
Comment thread docs/deployments/oc10-app.md
micbar
micbar reviewed Dec 8, 2020
View reviewed changes
Comment thread Makefile.release
micbar
micbar reviewed Dec 8, 2020
View reviewed changes
Comment thread Makefile.release Outdated
micbar
micbar suggested changes Dec 8, 2020
View reviewed changes

@micbar micbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@LukasHirt

LukasHirt commented Dec 8, 2020

Copy link
Copy Markdown
Collaborator Author

@micbar Ready for re-review. Both comments addressed

@micbar

micbar commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

tested it. Seems to work. We will test the details in qa.

micbar
micbar approved these changes Dec 8, 2020
View reviewed changes

@micbar micbar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Super Fast progress!

@LukasHirt

LukasHirt commented Dec 8, 2020

Copy link
Copy Markdown
Collaborator Author

Had twice in a row failures in CI. I tried to rebase the PR, maybe that'll help

@LukasHirt
LukasHirt merged commit 54b7fb7 into master Dec 8, 2020
@LukasHirt
LukasHirt deleted the oc10-app branch December 8, 2020 15:54
ownclouders pushed a commit that referenced this pull request Dec 8, 2020
Lukas Hirt
commit 54b7fb7
a963eeb 
Merge: 7387234 71f88cc
Author: Lukas Hirt <lhirt@owncloud.com>
Date:   Tue Dec 8 16:54:40 2020 +0100

    Merge pull request #4427 from owncloud/oc10-app
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kulmann kulmann Awaiting requested review from kulmann
3 more reviewers
@phil-davis phil-davis phil-davis left review comments
@micbar micbar micbar approved these changes
@pmaier1 pmaier1 pmaier1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LukasHirt LukasHirt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasHirt @micbar @phil-davis @pmaier1